paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 09:27:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gear_menu: Delete unused Bootstrap tabs code.

Browse Source 
Before 2017, Zulip's manage streams and settings UIs were tab in the
same pane position as our current message feed and recent topics.

That original implementation was implemented using Bootstrap tabs;
while it hasn't been in use for years, we had a bunch of stale code
related to it leftover in this module.
This commit is contained in:
Tim Abbott
2022-11-20 18:52:18 -08:00
parent f29e748e3b
commit 2a3f708e9a
12 changed files with 6 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/node_tests/hashchange.js
View File

@@ -137,10 +137,6 @@ function test_helper({override, change_tab}) {
stub(ui_report, "error");
if (change_tab) {
override(ui_util, "change_tab_to", (hash) => {
events.push("change_tab_to " + hash);
});
override(narrow, "activate", (terms) => {
narrow_terms = terms;
events.push("narrow.activate");
@@ -190,7 +186,6 @@ run_test("hash_interactions", ({override}) => {
helper.assert_events([
[overlays, "close_for_hash_change"],
[message_viewport, "stop_auto_scrolling"],
"change_tab_to #message_feed_container",
[narrow, "deactivate"],
[floating_recipient_bar, "update"],
]);
@@ -200,7 +195,6 @@ run_test("hash_interactions", ({override}) => {
helper.assert_events([
[overlays, "close_for_hash_change"],
[message_viewport, "stop_auto_scrolling"],
"change_tab_to #message_feed_container",
[narrow, "deactivate"],
[floating_recipient_bar, "update"],
]);
@@ -225,7 +219,6 @@ run_test("hash_interactions", ({override}) => {
helper.assert_events([
[overlays, "close_for_hash_change"],
[message_viewport, "stop_auto_scrolling"],
"change_tab_to #message_feed_container",
"narrow.activate",
[floating_recipient_bar, "update"],
]);
@@ -239,7 +232,6 @@ run_test("hash_interactions", ({override}) => {
helper.assert_events([
[overlays, "close_for_hash_change"],
[message_viewport, "stop_auto_scrolling"],
"change_tab_to #message_feed_container",
"narrow.activate",
[floating_recipient_bar, "update"],
]);
@@ -254,7 +246,6 @@ run_test("hash_interactions", ({override}) => {
helper.assert_events([
[overlays, "close_for_hash_change"],
[message_viewport, "stop_auto_scrolling"],
"change_tab_to #message_feed_container",
[ui_report, "error"],
]);

3
frontend_tests/node_tests/narrow_activate.js
View File

@@ -35,7 +35,6 @@ const search = mock_esm("../../static/js/search");
const stream_list = mock_esm("../../static/js/stream_list");
const top_left_corner = mock_esm("../../static/js/top_left_corner");
const typing_events = mock_esm("../../static/js/typing_events");
const ui_util = mock_esm("../../static/js/ui_util");
const unread_ops = mock_esm("../../static/js/unread_ops");
mock_esm("../../static/js/recent_topics_util", {
is_visible() {},
@@ -90,7 +89,6 @@ function test_helper() {
stub(top_left_corner, "handle_narrow_activated");
stub(typing_events, "render_notifications_for_narrow");
stub(compose_actions, "update_narrow_to_recipient_visibility");
stub(ui_util, "change_tab_to");
stub(unread_ops, "process_visible");
stub(compose_closed_ui, "update_buttons_for_stream");
stub(compose_closed_ui, "update_buttons_for_private");
@@ -192,7 +190,6 @@ run_test("basics", () => {
[message_scroll, "hide_indicators"],
[notifications, "clear_compose_notifications"],
[notifications, "redraw_title"],
[ui_util, "change_tab_to"],
[unread_ops, "process_visible"],
[hashchange, "save_narrow"],
[compose_closed_ui, "update_buttons_for_stream"],

1
frontend_tests/node_tests/search_future.js
View File

@@ -21,7 +21,6 @@ mock_esm("../../static/js/search_pill_widget", {
},
});
mock_esm("../../static/js/ui_util", {
change_tab_to: noop,
place_caret_at_end: noop,
});

5
frontend_tests/node_tests/search_now.js
View File

@@ -9,14 +9,9 @@ const {page_params} = require("../zjsunit/zpage_params");
page_params.search_pills_enabled = false;
const noop = () => {};
const narrow = mock_esm("../../static/js/narrow");
const narrow_state = mock_esm("../../static/js/narrow_state");
const search_suggestion = mock_esm("../../static/js/search_suggestion");
mock_esm("../../static/js/ui_util", {
change_tab_to: noop,
});
const Filter = {};