paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

icons: Add icon-independent .message-actions-menu-button class.

Browse Source 
Behavior shouldn't depend on the specific names of icon classes.
This commit is contained in:
Karl Stolley
2023-07-17 15:01:05 -05:00
committed by Tim Abbott
parent 735a42d037
commit 2a8f14e40a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/popover_menus.js
View File

@@ -234,7 +234,7 @@ export function toggle_message_actions_menu(message) {
} }
message_viewport.maybe_scroll_to_show_message_top(); message_viewport.maybe_scroll_to_show_message_top();
const $popover_reference = $(".selected_message .actions_hover .zulip-icon-ellipsis-v-solid"); const $popover_reference = $(".selected_message .actions_hover .message-actions-menu-button");
message_actions_popover_keyboard_toggle = true; message_actions_popover_keyboard_toggle = true;
$popover_reference.trigger("click"); $popover_reference.trigger("click");
return true; return true;
@@ -695,7 +695,7 @@ export function initialize() {
}, },
}); });
register_popover_menu(".actions_hover .zulip-icon-ellipsis-v-solid", { register_popover_menu(".actions_hover .message-actions-menu-button", {
// 320px is our minimum supported width for mobile. We will allow the value to flex // 320px is our minimum supported width for mobile. We will allow the value to flex
// to a max of 350px but we shouldn't make the popover wider than this. // to a max of 350px but we shouldn't make the popover wider than this.
maxWidth: "min(max(320px, 100vw), 350px)", maxWidth: "min(max(320px, 100vw), 350px)",

2
web/templates/message_controls.hbs
View File

@@ -11,7 +11,7 @@
{{#unless msg/locally_echoed}} {{#unless msg/locally_echoed}}
<div class="actions_hover message_control_button" data-tooltip-template-id="message-actions-tooltip-template" > <div class="actions_hover message_control_button" data-tooltip-template-id="message-actions-tooltip-template" >
<i class="zulip-icon zulip-icon-more-vertical" role="button" aria-haspopup="true" tabindex="0" aria-label="{{t 'Message actions' }}"></i> <i class="message-actions-menu-button zulip-icon zulip-icon-more-vertical" role="button" aria-haspopup="true" tabindex="0" aria-label="{{t 'Message actions' }}"></i>
</div> </div>
{{/unless}} {{/unless}}