paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 04:43:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add unread.get_msg_ids_for_stream().

Browse Source
This commit is contained in:
Steve Howell
2018-05-01 19:22:49 +00:00
committed by Tim Abbott
parent c432acb436
commit 2b35f26b88
2 changed files with 46 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
frontend_tests/node_tests/unread.js
View File

@@ -86,6 +86,9 @@ var zero_counts = {
var msg_ids = unread.get_msg_ids_for_topic(stream_id, 'LuNcH');
assert.deepEqual(msg_ids, []);
msg_ids = unread.get_msg_ids_for_stream(stream_id);
assert.deepEqual(msg_ids, []);
unread.process_loaded_messages([message, other_message]);
assert.deepEqual(unread.get_unread_message_ids([15, 16]), [15, 16]);
@@ -223,12 +226,14 @@ stream_data.get_stream_id = function () {
assert.equal(counts.stream_count.get(stream_id), 1);
assert.equal(counts.home_unread_messages, 1);
assert.equal(unread.num_unread_for_stream(stream_id), 1);
assert.deepEqual(unread.get_msg_ids_for_stream(stream_id), [message.id]);
muting.add_muted_topic('social', 'test_muting');
counts = unread.get_counts();
assert.equal(counts.stream_count.get(stream_id), 0);
assert.equal(counts.home_unread_messages, 0);
assert.equal(unread.num_unread_for_stream(stream_id), 0);
assert.deepEqual(unread.get_msg_ids_for_stream(stream_id), []);
assert.equal(unread.num_unread_for_stream(unknown_stream_id), 0);
}());
@@ -239,6 +244,13 @@ stream_data.get_stream_id = function () {
unread.declare_bankruptcy();
var stream_id = 301;
stream_data.get_sub_by_id = function (arg) {
if (arg === stream_id) {
return {name: 'Some Stream'};
}
};
var count = unread.num_unread_for_topic(stream_id, 'lunch');
assert.equal(count, 0);
@@ -264,6 +276,9 @@ stream_data.get_stream_id = function () {
var msg_ids = unread.get_msg_ids_for_topic(stream_id, 'LuNcH');
assert.deepEqual(msg_ids, _.range(1, 501));
msg_ids = unread.get_msg_ids_for_stream(stream_id);
assert.deepEqual(msg_ids, _.range(1, 501));
for (i = 0; i < num_msgs; i += 1) {
message.id = i+1;
unread.mark_as_read(message.id);
@@ -274,6 +289,9 @@ stream_data.get_stream_id = function () {
msg_ids = unread.get_msg_ids_for_topic(stream_id, 'LuNcH');
assert.deepEqual(msg_ids, []);
msg_ids = unread.get_msg_ids_for_stream(stream_id);
assert.deepEqual(msg_ids, []);
}());
@@ -534,7 +552,10 @@ stream_data.get_stream_id = function () {
unread.declare_bankruptcy();
const stream_id = 999;
const msg_ids = unread.get_msg_ids_for_topic(stream_id, 'LuNcH');
var msg_ids = unread.get_msg_ids_for_topic(stream_id, 'LuNcH');
assert.deepEqual(msg_ids, []);
msg_ids = unread.get_msg_ids_for_stream(stream_id);
assert.deepEqual(msg_ids, []);
}());

24
static/js/unread.js
View File

@@ -309,6 +309,26 @@ exports.unread_topic_counter = (function () {
return topic_bucket.count();
};
self.get_msg_ids_for_stream = function (stream_id) {
var per_stream_bucketer = bucketer.get_bucket(stream_id);
if (!per_stream_bucketer) {
return [];
}
var topic_lists = [];
per_stream_bucketer.each(function (msgs, topic) {
var sub = stream_data.get_sub_by_id(stream_id);
if (sub && !muting.is_topic_muted(sub.name, topic)) {
topic_lists.push(msgs.members());
}
});
var ids = [].concat.apply([], topic_lists);
return util.sorted_ids(ids);
};
self.get_msg_ids_for_topic = function (stream_id, topic) {
var per_stream_bucketer = bucketer.get_bucket(stream_id);
if (!per_stream_bucketer) {
@@ -469,6 +489,10 @@ exports.num_unread_for_person = function (user_ids_string) {
return exports.unread_pm_counter.num_unread(user_ids_string);
};
exports.get_msg_ids_for_stream = function (stream_id) {
return exports.unread_topic_counter.get_msg_ids_for_stream(stream_id);
};
exports.get_msg_ids_for_topic = function (stream_id, subject) {
return exports.unread_topic_counter.get_msg_ids_for_topic(stream_id, subject);
};