paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-19 14:08:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

zjquery: Tell user why using tags as selector is invalid.

Browse Source 
Like using $('input') is too broad a selector and shouldn't
be used in the codebase. With this error messages, contributors
can easily understand that now.
This commit is contained in:
Aman Agrawal
2021-02-22 13:37:49 +00:00
committed by Steve Howell
parent 269457c58b
commit 2b8921bf67
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frontend_tests/zjsunit/zjquery.js
View File

@@ -29,8 +29,15 @@ function verify_selector_for_zulip(selector) {
(selector.includes("[") && selector.indexOf("]") >= selector.indexOf("[")); (selector.includes("[") && selector.indexOf("]") >= selector.indexOf("["));
if (!is_valid) { if (!is_valid) {
// Check if selector has only english alphabets and space.
// Then, the user is probably trying to use a tag as a selector
// like $('div a').
if (/^[ A-Za-z]+$/.test(selector)) {
throw new Error("Selector too broad! Use id, class or attributes of target instead.");
} else {
throw new Error("Invalid selector: " + selector + " Use $.create() maybe?"); throw new Error("Invalid selector: " + selector + " Use $.create() maybe?");
} }
}
} }
function make_event_store(selector) { function make_event_store(selector) {