paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_push_notifications: Remove mocking of get_base_payload().

Browse Source 
Mocking `get_base_payload()` verifies the wrong output
when the code is actually correct. So, its better that
we call the real function here, especially when we are
adding the Apple case.
This commit is contained in:
Hashir Sarwar
2020-06-16 09:32:34 +05:00
committed by Tim Abbott
parent 62aab0d9ee
commit 2bc34bb3ff
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
zerver/tests/test_push_notifications.py
View File

@@ -923,15 +923,16 @@ class HandlePushNotificationTest(PushNotificationTest):
with self.settings(PUSH_NOTIFICATION_BOUNCER_URL=True), \
mock.patch('zerver.lib.push_notifications'
'.send_notifications_to_bouncer') as mock_send_android, \
mock.patch('zerver.lib.push_notifications.get_base_payload',
return_value={'gcm': True}):
'.send_notifications_to_bouncer') as mock_send_android:
handle_remove_push_notification(user_profile.id, [message.id])
mock_send_android.assert_called_with(
user_profile.id,
{},
{
'gcm': True,
'server': 'testserver',
'realm_id': self.sender.realm.id,
'realm_uri': 'http://zulip.testserver',
'user_id': self.user_profile.id,
'event': 'remove',
'zulip_message_ids': str(message.id),
'zulip_message_id': message.id,
@@ -956,14 +957,15 @@ class HandlePushNotificationTest(PushNotificationTest):
kind=PushDeviceToken.GCM))
with mock.patch('zerver.lib.push_notifications'
'.send_android_push_notification') as mock_send_android, \
mock.patch('zerver.lib.push_notifications.get_base_payload',
return_value={'gcm': True}):
'.send_android_push_notification') as mock_send_android:
handle_remove_push_notification(self.user_profile.id, [message.id])
mock_send_android.assert_called_with(
android_devices,
{
'gcm': True,
'server': 'testserver',
'realm_id': self.sender.realm.id,
'realm_uri': 'http://zulip.testserver',
'user_id': self.user_profile.id,
'event': 'remove',
'zulip_message_ids': str(message.id),
'zulip_message_id': message.id,