paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 08:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

documentation_crawler: Remove wrongly inverted skip_check_fragment flag.

Browse Source 
Due to a missing `not`, this incorrectly skipped checking fragments
for everything *other* than the /help documentation!

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2025-09-03 15:47:08 -07:00
committed by Tim Abbott
parent a914c8e53f
commit 2bf20e02f2
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/documentation_crawler/documentation_crawler/spiders/common/spiders.py
View File

@@ -184,7 +184,7 @@ class BaseDocumentationSpider(scrapy.Spider):
"There is no local directory associated with the GitHub URL: %s", url "There is no local directory associated with the GitHub URL: %s", url
) )
return return
elif getattr(self, "skip_check_fragment", False) and split_url.fragment != "": elif split_url.fragment != "":
dont_filter = True dont_filter = True
callback = self.check_fragment callback = self.check_fragment
if getattr(self, "skip_external", False) and self._is_external_link(url): if getattr(self, "skip_external", False) and self._is_external_link(url):

9
tools/test-help-documentation
View File

@@ -75,14 +75,7 @@ with (
), ),
): ):
ret_help_doc = subprocess.call( ret_help_doc = subprocess.call(
[ ["scrapy", "crawl_with_status", *extra_args, "help_documentation_crawler"],
"scrapy",
"crawl_with_status",
*extra_args,
"-a",
"skip_check_fragment=set",
"help_documentation_crawler",
],
cwd="tools/documentation_crawler", cwd="tools/documentation_crawler",
) )
extra_args += ["-a", "validate_html=set"] extra_args += ["-a", "validate_html=set"]