paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 17:36:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_reply: Remove unnecessary pm_recipient being set.

Browse Source 
`pm_recipient` is already set in `else` case unconditionally,
so setting it early is not required.
This commit is contained in:
Aman Agrawal
2023-10-07 06:59:21 +00:00
committed by Tim Abbott
parent bb740ca65e
commit 2c4156e239
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/compose_reply.js
View File

@@ -97,9 +97,7 @@ export function respond_to_message(opts) {
if (msg_type === "stream") { if (msg_type === "stream") {
stream_id = message.stream_id; stream_id = message.stream_id;
topic = message.topic; topic = message.topic;
} else { } else if (opts.reply_type === "personal") {
pm_recipient = message.reply_to;
if (opts.reply_type === "personal") {
// reply_to for direct messages is everyone involved, so for // reply_to for direct messages is everyone involved, so for
// personals replies we need to set the direct message // personals replies we need to set the direct message
// recipient to just the sender // recipient to just the sender
@@ -107,7 +105,6 @@ export function respond_to_message(opts) {
} else { } else {
pm_recipient = people.pm_reply_to(message); pm_recipient = people.pm_reply_to(message);
} }
}
compose_actions.start(msg_type, { compose_actions.start(msg_type, {
stream_id, stream_id,