paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 11:22:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

subs: Update checkbox states when values are changed off-page.

Browse Source 
Previously, if you toggled the in_home_view checkbox either in a
different browser or via the button in the sidebar menus, it didn't
actually update the visible checkbox state in the streams page,
resulting in some potentially very confusing interactions.

(imported from commit 3424430231f89a23e970a2f1bfec82c6eb0d6735)
This commit is contained in:
Tim Abbott
2013-07-16 16:47:30 -04:00
parent 56810391de
commit 2cda98609b
1 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
zephyr/static/js/subs.js
View File

@@ -196,9 +196,11 @@ function stream_home_view_clicked(e) {
subs.toggle_home(stream);
}
exports.toggle_home = function (stream_name) {
var sub = get_sub(stream_name);
sub.in_home_view = ! sub.in_home_view;
function update_in_home_view(sub, value) {
if (sub.in_home_view === value) {
return;
}
sub.in_home_view = value;
setTimeout(function () {
var scroll_offset, saved_ypos;
@@ -240,10 +242,24 @@ exports.toggle_home = function (stream_name) {
}, 0);
exports.maybe_toggle_all_messages();
stream_list.set_in_home_view(sub.name, sub.in_home_view);
var in_home_view_checkbox = $("#subscription_" + sub.id + " #sub_setting_in_home_view .sub_setting_control");
in_home_view_checkbox.attr('checked', value);
}
exports.toggle_home = function (stream_name) {
var sub = get_sub(stream_name);
update_in_home_view(sub, ! sub.in_home_view);
set_stream_property(stream_name, 'in_home_view', sub.in_home_view);
stream_list.set_in_home_view(stream_name, sub.in_home_view);
};
function update_stream_notifications(sub, value) {
var in_home_view_checkbox = $("#subscription_" + sub.id + " #sub_setting_notifications .sub_setting_control");
in_home_view_checkbox.attr('checked', value);
sub.notifications = value;
}
function stream_notifications_clicked(e) {
var sub_row = $(e.target).closest('.subscription_row');
var stream = sub_row.find('.subscription_name').text();
@@ -667,11 +683,10 @@ exports.update_subscription_properties = function (stream_name, property, value)
update_stream_color(stream_name, value, {update_historical: true});
break;
case 'in_home_view':
sub[property] = value;
stream_list.set_in_home_view(stream_name, sub.in_home_view);
update_in_home_view(sub, value);
break;
case 'notifications':
sub[property] = value;
update_stream_notifications(sub, value);
break;
default:
blueslip.warn("Unexpected subscription property type", {property: property,