From 2d118f098a100ec978fd28d8edad24e4b4d0e500 Mon Sep 17 00:00:00 2001 From: Lalit Date: Fri, 21 Apr 2023 08:49:45 +0530 Subject: [PATCH] compose: Fix opening stream picker by triggering click event. We should trigger click event to open up the dropdown popup instead of using `.dropdown("toggle")` because we want to clear the search state when opening up the popup and the logic for that is registered in `on-click` handler defined in `dropdown_list_widget`. Fixes: #25218 --- web/src/compose_recipient.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/web/src/compose_recipient.js b/web/src/compose_recipient.js index 6ba2099fbf..96be3843f7 100644 --- a/web/src/compose_recipient.js +++ b/web/src/compose_recipient.js @@ -94,7 +94,10 @@ export function open_compose_stream_dropup() { if ($("#id_compose_select_stream").hasClass("open")) { return; } - $("#id_compose_select_stream > .dropdown-toggle").dropdown("toggle"); + // We trigger a click rather than directly toggling the element; + // this is important to ensure the filter text gets cleared when + // reopening the widget after previous use. + $("#id_compose_select_stream > .dropdown-toggle").trigger("click"); } export function on_compose_select_stream_update(new_value) {