tools/lister.py: Use default arguments in add_argument.

Use the `default` parameter of ArgumentParser.add_argument
instead of manually setting default using the `x = x or []` pattern.
This commit is contained in:
Eklavya Sharma
2016-05-01 07:01:52 +05:30
parent aa3549097d
commit 2d3f9c8fb9

View File

@@ -95,18 +95,17 @@ def list_files(targets=[], ftypes=[], use_shebang=True, modified_only=False,
if __name__=="__main__":
parser = argparse.ArgumentParser(description="List files tracked by git and optionally filter by type")
parser.add_argument('targets', nargs='*',
parser.add_argument('targets', nargs='*', default=[],
help='''files and directories to include in the result.
If this is not specified, the current directory is used''')
parser.add_argument('-m', '--modified', action='store_true', default=False, help='list only modified files')
parser.add_argument('-f', '--ftypes', nargs='+',
parser.add_argument('-f', '--ftypes', nargs='+', default=[],
help="list of file types to filter on. All files are included if this option is absent")
parser.add_argument('--ext-only', dest='extonly', action='store_true', default=False, help='only use extension to determine file type')
parser.add_argument('--exclude', nargs='+', help='list of files and directories to exclude from listing')
parser.add_argument('--ext-only', dest='extonly', action='store_true', default=False,
help='only use extension to determine file type')
parser.add_argument('--exclude', nargs='+', default=[],
help='list of files and directories to exclude from listing')
args = parser.parse_args()
args.targets = args.targets or []
args.ftypes = args.ftypes or []
args.exclude = args.exclude or []
listing = list_files(targets=args.targets, ftypes=args.ftypes, use_shebang=not args.extonly,
modified_only=args.modified, exclude=args.exclude)
for l in listing: