diff --git a/static/js/click_handlers.js b/static/js/click_handlers.js index 950b5b5193..94e97813bc 100644 --- a/static/js/click_handlers.js +++ b/static/js/click_handlers.js @@ -639,7 +639,7 @@ $(function () { $("#settings_overlay_container").on("click", function (e) { var $target = $(e.target); if ($target.is(".exit-sign, .exit")) { - hashchange.exit_settings(); + hashchange.exit_modal(); } }); diff --git a/static/js/drafts.js b/static/js/drafts.js index ca64545121..1d58f5a7a2 100644 --- a/static/js/drafts.js +++ b/static/js/drafts.js @@ -210,7 +210,7 @@ exports.launch = function () { }; exports.close = function () { - hashchange.exit_settings(); + hashchange.exit_modal(); $("#draft_overlay").removeClass("show"); }; diff --git a/static/js/hashchange.js b/static/js/hashchange.js index c537102eeb..df8c615888 100644 --- a/static/js/hashchange.js +++ b/static/js/hashchange.js @@ -204,7 +204,7 @@ function do_hashchange(from_reload) { // return `true` for the current state -- we want to ignore hash changes from // within the settings page. The previous hash however should return `false` as it // was outside of the scope of settings. -// there is then an `exit_settings` function that allows the hash to change exactly +// there is then an `exit_modal` function that allows the hash to change exactly // once without triggering any events. This allows the hash to reset back from // a settings page to the previous view available before the settings page // (eg. narrow/is/private). This saves the state, scroll position, and makes the @@ -326,7 +326,7 @@ exports.close_modals = function () { $("[data-overlay]").removeClass("show"); }; -exports.exit_settings = function (callback) { +exports.exit_modal = function (callback) { if (should_ignore(window.location.hash)) { ui.blur_active_element(); ignore.flag = true; diff --git a/static/js/subs.js b/static/js/subs.js index 93bca734e6..e454c51414 100644 --- a/static/js/subs.js +++ b/static/js/subs.js @@ -821,7 +821,7 @@ Object.defineProperty(exports, "is_open", { }); exports.close = function () { - hashchange.exit_settings(); + hashchange.exit_modal(); meta.is_open = false; $("#subscription_overlay").removeClass("show"); subs.remove_miscategorized_streams();