paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 17:36:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom_check: Detect incorrect use of assertTrue.

Browse Source 
This commit adds a check to avoid the use of assertTrue
for cases like: assertTrue(len(data) == 2).
We should use assert_length, assertGreater, or
assertGreaterEqual, whatever suits, in cases like these.
This commit is contained in:
akshatdalton
2021-07-13 17:49:03 +00:00
committed by Tim Abbott
parent 3ea1ff7665
commit 2e4a333133
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/linter_lib/custom_check.py
View File

@@ -277,6 +277,16 @@ python_rules = RuleList(
"good_lines": ["assert_length(data, 2)"], "good_lines": ["assert_length(data, 2)"],
"bad_lines": ["assertEqual(len(data), 2)"], "bad_lines": ["assertEqual(len(data), 2)"],
}, },
{
"pattern": "assertTrue[(]len[(][^ ]*[)]",
"description": "Use assert_length or assertGreater helper instead of assertTrue(len(..) ..).",
"good_lines": ["assert_length(data, 2)", "assertGreater(len(data), 2)"],
"bad_lines": [
"assertTrue(len(data) == 2)",
"assertTrue(len(data) >= 2)",
"assertTrue(len(data) > 2)",
],
},
{ {
"pattern": r"#\s*type:\s*ignore(?!\[[^][]+\] +# +\S)", "pattern": r"#\s*type:\s*ignore(?!\[[^][]+\] +# +\S)",
"exclude": {"tools/tests", "zerver/lib/test_runner.py", "zerver/tests"}, "exclude": {"tools/tests", "zerver/lib/test_runner.py", "zerver/tests"},