paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

activity: Delete render_empty_user_list_message_if_needed.

Browse Source 
This was added in b387ca4, before we had
`buddy_list.update_empty_list_placeholders`

Now it's not only duplicating that functionality, but will soon
maybe run at the wrong time once the buddy list `populate` starts
making `void` calls to `async` empty list placeholder code.
This commit is contained in:
Evy Kassirer
2025-04-19 19:59:15 +02:00
committed by Tim Abbott
parent eaa358dc88
commit 2f2cd72f26
2 changed files with 0 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
web/tests/activity.test.cjs
View File

@@ -469,29 +469,6 @@ test("first/prev/next", ({override, override_rewire, mock_template}) => {
assert.equal(buddy_list.next_key(fred.user_id), undefined);
});
test("render_empty_user_list_message", ({override, mock_template}) => {
const empty_list_message = "No matching users.";
mock_template("empty_list_widget_for_list.hbs", false, (data) => {
assert.equal(data.empty_list_message, empty_list_message);
return "<empty-list-stub>";
});
let $appended_data;
override(buddy_list, "$container", {
append($data) {
$appended_data = $data;
},
attr(name) {
assert.equal(name, "data-search-results-empty");
return empty_list_message;
},
children: () => [],
});
activity_ui.render_empty_user_list_message_if_needed(buddy_list.$container);
assert.equal($appended_data.selector, "<empty-list-stub>");
});
test("insert_one_user_into_empty_list", ({override, mock_template}) => {
override(user_settings, "user_list_style", 2);