paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 10:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

backend: Support user IDs for sending typing notifications.

Browse Source 
This is a part of our efforts surrounding #9474.
This commit is contained in:
Eeshan Garg
2018-08-28 17:18:47 -02:30
parent 8f1dba6aad
commit 2f634f8c06
2 changed files with 110 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/lib/actions.py
View File

@@ -1624,15 +1624,21 @@ def check_send_typing_notification(sender: UserProfile, notification_to: Sequenc
# check_typing_notification:
# Returns typing notification ready for sending with do_send_typing_notification on success
# or the error message (string) on error.
def check_typing_notification(sender: UserProfile, notification_to: Sequence[str],
def check_typing_notification(sender: UserProfile,
notification_to: Union[Sequence[str], Sequence[int]],
operator: str) -> Dict[str, Any]:
if len(notification_to) == 0:
raise JsonableError(_('Missing parameter: \'to\' (recipient)'))
elif operator not in ('start', 'stop'):
raise JsonableError(_('Invalid \'op\' value (should be start or stop)'))
try:
recipient = recipient_for_emails(notification_to, False,
sender, sender)
if isinstance(notification_to[0], str):
emails = cast(Sequence[str], notification_to)
recipient = recipient_for_emails(emails, False, sender, sender)
elif isinstance(notification_to[0], int):
user_ids = cast(Sequence[int], notification_to)
recipient = recipient_for_user_ids(user_ids, sender)
except ValidationError as e:
assert isinstance(e.messages[0], str)
raise JsonableError(e.messages[0])