paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 19:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: Rename update_starred to update_starred_view.

Browse Source
This commit is contained in:
Joshua Pan
2018-08-01 10:02:38 -07:00
committed by Tim Abbott
parent 5e70577f84
commit 2fcc54ac14
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/dispatch.js
View File

@@ -1015,7 +1015,7 @@ with_overrides(function (override) {
// update_message_flags__starred // update_message_flags__starred
var event = event_fixtures.update_message_flags__starred; var event = event_fixtures.update_message_flags__starred;
global.with_stub(function (stub) { global.with_stub(function (stub) {
override('ui.update_starred', stub.f); override('ui.update_starred_view', stub.f);
dispatch(event); dispatch(event);
var args = stub.get_args('message_id', 'new_value'); var args = stub.get_args('message_id', 'new_value');
assert_same(args.message_id, 99); assert_same(args.message_id, 99);

2
frontend_tests/node_tests/message_flags.js
View File

@@ -12,7 +12,7 @@ run_test('starred', () => {
var ui_updated; var ui_updated;
ui.update_starred = () => { ui.update_starred_view = () => {
ui_updated = true; ui_updated = true;
}; };

4
static/js/message_flags.js
View File

@@ -80,7 +80,7 @@ exports.save_uncollapsed = function (message) {
exports.update_starred_flag = function (message_id, new_value) { exports.update_starred_flag = function (message_id, new_value) {
var message = message_store.get(message_id); var message = message_store.get(message_id);
message.starred = new_value; message.starred = new_value;
ui.update_starred(message_id, new_value); ui.update_starred_view(message_id, new_value);
}; };
exports.toggle_starred = function (message) { exports.toggle_starred = function (message) {
@@ -95,7 +95,7 @@ exports.toggle_starred = function (message) {
message.starred = !message.starred; message.starred = !message.starred;
unread_ops.notify_server_message_read(message); unread_ops.notify_server_message_read(message);
ui.update_starred(message.id, message.starred); ui.update_starred_view(message.id, message.starred);
if (message.starred) { if (message.starred) {
send_flag_update(message, 'starred', 'add'); send_flag_update(message, 'starred', 'add');

2
static/js/ui.js
View File

@@ -78,7 +78,7 @@ exports.find_message = function (message_id) {
return message; return message;
}; };
exports.update_starred = function (message_id, new_value) { exports.update_starred_view = function (message_id, new_value) {
var starred = new_value; var starred = new_value;
// Avoid a full re-render, but update the star in each message // Avoid a full re-render, but update the star in each message