paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate people.reify() and mostly ignore unknown users.

Browse Source 
If I try to send a message to an unknown user (which is possible
for some types of realms), then I simply ignore them during the
send codepath, so that I don't later need to patch up their attributes.
This commit is contained in:
Steve Howell
2016-11-03 12:12:38 -07:00
committed by Tim Abbott
parent 15d44f8d71
commit 30e01306d9
4 changed files with 14 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
frontend_tests/node_tests/people.js
View File

@@ -84,30 +84,6 @@ var _ = global._;
assert.equal(person.full_name, 'Original');
}());
(function test_reify() {
var full_person = {
email: 'foo@example.com',
full_name: 'Foo Barson'
};
// If we don't have a skeleton object, this should quietly succeed.
people.reify(full_person);
var skeleton = {
email: 'foo@example.com',
full_name: 'foo@example.com',
skeleton: true
};
people.add(skeleton);
people.reify(full_person);
var person = people.get_by_email('foo@example.com');
assert.equal(person.full_name, 'Foo Barson');
// Our follow-up reify() call should also quietly succeed.
people.reify(full_person);
}());
(function test_get_rest_of_realm() {
var myself = {
email: 'myself@example.com',