paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

drafts: Move snapshot_message from compose to drafts

Browse Source 
Previously drafts called compose.snapshot_message which would then
get the message object from compose.create_message_object. This method often
checked for the validity of stream/user recipients which would often cause tracebacks.

The new method in drafts.snapshot message just gets the data from the fields and
stores them in the draft model without any additional checking.
This commit is contained in:
Sampriti Panda
2017-03-29 12:24:26 +05:30
committed by Tim Abbott
parent 400a2e0ff1
commit 32e76c2c60
4 changed files with 64 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
static/js/drafts.js
View File

@@ -63,8 +63,35 @@ var draft_model = (function () {
exports.draft_model = draft_model;
exports.snapshot_message = function () {
if (!compose_state.composing() || (compose.message_content() === "")) {
// If you aren't in the middle of composing the body of a
// message, don't try to snapshot.
return;
}
// Save what we can.
var message = {
type: compose_state.composing(),
content: compose.message_content(),
};
if (message.type === "private") {
var recipient = compose_state.recipient();
message.reply_to = recipient;
message.private_message_recipient = recipient;
} else {
message.stream = compose.stream_name();
var subject = compose.subject();
if (subject === "") {
subject = compose.empty_topic_placeholder();
}
message.subject = subject;
}
return message;
};
exports.update_draft = function () {
var draft = compose.snapshot_message();
var draft = drafts.snapshot_message();
var draft_id = $("#new_message_content").data("draft-id");
if (draft_id !== undefined) {