paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_feed_bottom_whitespace: Rename variable for general use.

Browse Source 
Rename so that the loading indicator an be used by other views
as well.
This commit is contained in:
Aman Agrawal
2025-06-10 09:27:22 +05:30
committed by Tim Abbott
parent bc55c831ea
commit 331bb09cdd
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/message_feed_loading.ts
View File

@@ -25,7 +25,7 @@ export function show_loading_newer(): void {
if (!loading_newer_messages_indicator_showing) { if (!loading_newer_messages_indicator_showing) {
$(".bottom-messages-logo").show(); $(".bottom-messages-logo").show();
$(".bottom-messages-logo").toggleClass("loading", true); $(".bottom-messages-logo").toggleClass("loading", true);
loading.make_indicator($("#loading_newer_messages_indicator"), {abs_positioned: true}); loading.make_indicator($("#loading_more_indicator"), {abs_positioned: true});
loading_newer_messages_indicator_showing = true; loading_newer_messages_indicator_showing = true;
} }
} }
@@ -34,7 +34,7 @@ export function hide_loading_newer(): void {
if (loading_newer_messages_indicator_showing) { if (loading_newer_messages_indicator_showing) {
$(".bottom-messages-logo").hide(); $(".bottom-messages-logo").hide();
$(".bottom-messages-logo").toggleClass("loading", false); $(".bottom-messages-logo").toggleClass("loading", false);
loading.destroy_indicator($("#loading_newer_messages_indicator")); loading.destroy_indicator($("#loading_more_indicator"));
loading_newer_messages_indicator_showing = false; loading_newer_messages_indicator_showing = false;
} }
} }

6
web/styles/zulip.css
View File

@@ -1219,12 +1219,12 @@ nav {
} }
#loading_older_messages_indicator, #loading_older_messages_indicator,
#loading_newer_messages_indicator { #loading_more_indicator {
margin: 10px; margin: 10px;
} }
#loading_older_messages_indicator_box_container, #loading_older_messages_indicator_box_container,
#loading_newer_messages_indicator_box_container { #loading_more_indicator_box_container {
position: absolute; position: absolute;
left: 50%; left: 50%;
@@ -1237,7 +1237,7 @@ nav {
} }
#loading_older_messages_indicator_box, #loading_older_messages_indicator_box,
#loading_newer_messages_indicator_box { #loading_more_indicator_box {
position: relative; position: relative;
left: -1.3571em; /* 50% of 38px = 19px at 14px/em */ left: -1.3571em; /* 50% of 38px = 19px at 14px/em */
top: -3.0714em; /* -43px at 14px/em */ top: -3.0714em; /* -43px at 14px/em */

2
web/templates/message_feed_bottom_whitespace.hbs
View File

@@ -4,4 +4,4 @@
<path d="M566.66 527.25c0 33.03-24.23 60.05-53.84 60.05H260.29c-29.61 0-53.84-27.02-53.84-60.05 0-20.22 9.09-38.2 22.93-49.09l134.37-120c2.5-2.14 5.74 1.31 3.94 4.19l-49.29 98.69c-1.38 2.76.41 6.16 3.25 6.16h191.18c29.61 0 53.83 27.03 53.83 60.05zm0-281.39c0 20.22-9.09 38.2-22.93 49.09l-134.37 120c-2.5 2.14-5.74-1.31-3.94-4.19l49.29-98.69c1.38-2.76-.41-6.16-3.25-6.16H260.29c-29.61 0-53.84-27.02-53.84-60.05s24.23-60.05 53.84-60.05h252.54c29.61 0 53.83 27.02 53.83 60.05z"/> <path d="M566.66 527.25c0 33.03-24.23 60.05-53.84 60.05H260.29c-29.61 0-53.84-27.02-53.84-60.05 0-20.22 9.09-38.2 22.93-49.09l134.37-120c2.5-2.14 5.74 1.31 3.94 4.19l-49.29 98.69c-1.38 2.76.41 6.16 3.25 6.16h191.18c29.61 0 53.83 27.03 53.83 60.05zm0-281.39c0 20.22-9.09 38.2-22.93 49.09l-134.37 120c-2.5 2.14-5.74-1.31-3.94-4.19l49.29-98.69c1.38-2.76-.41-6.16-3.25-6.16H260.29c-29.61 0-53.84-27.02-53.84-60.05s24.23-60.05 53.84-60.05h252.54c29.61 0 53.83 27.02 53.83 60.05z"/>
</svg> </svg>
</div> </div>
<div id="loading_newer_messages_indicator"></div> <div id="loading_more_indicator"></div>