paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 20:02:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

people: Cache results of remove_diacritics.

Browse Source
This commit is contained in:
evykassirer
2024-03-05 10:51:27 -08:00
committed by Tim Abbott
parent 1db2d0fd0f
commit 33484e7ac3
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/people.ts
View File

@@ -28,6 +28,8 @@ export type User = {
delivery_email: string | null; delivery_email: string | null;
email: string; email: string;
full_name: string; full_name: string;
// used for caching result of remove_diacritics.
name_with_diacritics_removed?: string;
date_joined: string; date_joined: string;
is_active: boolean; is_active: boolean;
is_owner: boolean; is_owner: boolean;
@@ -1196,9 +1198,12 @@ export function build_termlet_matcher(termlet: string): (user: User) => boolean
return function (user: User): boolean { return function (user: User): boolean {
let full_name = user.full_name; let full_name = user.full_name;
if (is_ascii) {
// Only ignore diacritics if the query is plain ascii // Only ignore diacritics if the query is plain ascii
full_name = typeahead.remove_diacritics(full_name); if (is_ascii) {
if (user.name_with_diacritics_removed === undefined) {
user.name_with_diacritics_removed = typeahead.remove_diacritics(full_name);
}
full_name = user.name_with_diacritics_removed;
} }
const names = full_name.toLowerCase().split(" "); const names = full_name.toLowerCase().split(" ");
@@ -1639,6 +1644,7 @@ export function set_full_name(person_obj: User, new_full_name: string): void {
track_duplicate_full_name(new_full_name, person_obj.user_id); track_duplicate_full_name(new_full_name, person_obj.user_id);
people_by_name_dict.set(new_full_name, person_obj); people_by_name_dict.set(new_full_name, person_obj);
person_obj.full_name = new_full_name; person_obj.full_name = new_full_name;
person_obj.name_with_diacritics_removed = undefined;
} }
export function set_custom_profile_field_data( export function set_custom_profile_field_data(