diff --git a/zerver/decorator.py b/zerver/decorator.py index 2496bd5919..e53e5e47eb 100644 --- a/zerver/decorator.py +++ b/zerver/decorator.py @@ -55,7 +55,7 @@ from zerver.lib.exceptions import ( from zerver.lib.queue import queue_json_publish from zerver.lib.rate_limiter import is_local_addr, rate_limit_request_by_ip, rate_limit_user from zerver.lib.request import REQ, RequestNotes, has_request_variables -from zerver.lib.response import json_method_not_allowed, json_success +from zerver.lib.response import json_method_not_allowed from zerver.lib.subdomains import get_subdomain, user_matches_subdomain from zerver.lib.timestamp import datetime_to_timestamp, timestamp_to_datetime from zerver.lib.users import is_2fa_verified @@ -962,7 +962,7 @@ def return_success_on_head_request( request: HttpRequest, /, *args: ParamT.args, **kwargs: ParamT.kwargs ) -> HttpResponse: if request.method == "HEAD": - return json_success(request) + return HttpResponse() return view_func(request, *args, **kwargs) return _wrapped_view_func diff --git a/zerver/tests/test_decorators.py b/zerver/tests/test_decorators.py index 73de336412..8d5703e7e0 100644 --- a/zerver/tests/test_decorators.py +++ b/zerver/tests/test_decorators.py @@ -1971,8 +1971,8 @@ class ReturnSuccessOnHeadRequestDecorator(ZulipTestCase): return json_response(msg="from_test_function") # nocoverage. isn't meant to be called response = test_function(request) - self.assert_json_success(response) - self.assertNotEqual(orjson.loads(response.content).get("msg"), "from_test_function") + self.assertEqual(response.status_code, 200) + self.assertEqual(response.content, b"") def test_returns_normal_response_if_request_method_is_not_head(self) -> None: class HeadRequest(HostRequestMock):