paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 10:26:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Add function to get union of members of two groups.

Browse Source 
This helps us important database queries when we want to perform a union
on the members of multiple user groups.
This commit is contained in:
Shubham Padia
2025-02-06 20:50:14 +00:00
committed by Tim Abbott
parent 121af1c815
commit 33ea2b366e
5 changed files with 62 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
zerver/lib/streams.py
View File

@@ -24,7 +24,7 @@ from zerver.lib.string_validation import check_stream_name
from zerver.lib.timestamp import datetime_to_timestamp
from zerver.lib.types import AnonymousSettingGroupDict, APIStreamDict
from zerver.lib.user_groups import (
get_recursive_group_members,
get_recursive_group_members_union_for_groups,
get_recursive_membership_groups,
get_role_based_system_groups_dict,
user_has_permission_for_group_setting,
@@ -181,17 +181,11 @@ def get_default_values_for_stream_permission_group_settings(
def get_user_ids_with_metadata_access_via_permission_groups(stream: Stream) -> set[int]:
stream_admin_user_ids = set(
get_recursive_group_members(stream.can_administer_channel_group_id).values_list(
"id", flat=True
)
return set(
get_recursive_group_members_union_for_groups(
[stream.can_add_subscribers_group_id, stream.can_administer_channel_group_id]
).values_list("id", flat=True)
)
stream_add_subscribers_group_user_ids = set(
get_recursive_group_members(stream.can_add_subscribers_group_id).values_list(
"id", flat=True
)
)
return stream_admin_user_ids | stream_add_subscribers_group_user_ids
@transaction.atomic(savepoint=False)