From 3422766c25c20f638b10cde1e8fd3c7c0684d69c Mon Sep 17 00:00:00 2001
From: Yashashvi Dave <yashashvidave@gmail.com>
Date: Fri, 1 Jun 2018 19:07:21 +0530
Subject: [PATCH] create stream: Fix widget for changing privacy doesn't render
 initially.

When admin user create new private stream, widget for changing privacy
of stream doesn't render. Because we render subscription-settings
template partially on subscription-add event, so this case wasn't
handled.

Fixes #9469
---
 static/js/subs.js                                 | 4 ++++
 static/templates/subscription_settings.handlebars | 4 +---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/static/js/subs.js b/static/js/subs.js
index 6d6bc2ec73..e7a31a110d 100644
--- a/static/js/subs.js
+++ b/static/js/subs.js
@@ -263,6 +263,10 @@ exports.update_settings_for_subscribed = function (sub) {
 
         button.toggleClass("checked");
         settings_button.text(i18n.t("Unsubscribe"));
+
+        if (sub.can_change_stream_permissions) {
+            $(".change-stream-privacy").show();
+        }
     } else {
         exports.add_sub_to_table(sub);
     }
diff --git a/static/templates/subscription_settings.handlebars b/static/templates/subscription_settings.handlebars
index 30bf84cdf6..efb7ce55fd 100644
--- a/static/templates/subscription_settings.handlebars
+++ b/static/templates/subscription_settings.handlebars
@@ -37,9 +37,7 @@
             <div class="subscription-type-text">
                 {{partial "subscription_type"}}
             </div>
-            {{#if can_change_stream_permissions}}
-            <a class="change-stream-privacy">[{{t "Change" }}]</a>
-            {{/if}}
+            <a class="change-stream-privacy" {{#unless can_change_stream_permissions}}style="display: none;"{{/unless}}>[{{t "Change" }}]</a>
         </div>
         <div class="regular_subscription_settings collapse {{#subscribed}}in{{/subscribed}}">
             <div class="subscription-config">