paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream: Fetch system groups in one query for group setting defaults.

Browse Source 
Right now, the number of queries has remained the same, but when we add
more settings in the future, we won't be increasing the number of
queries when iterating over stream permission group settings.
This commit is contained in:
Shubham Padia
2024-11-29 13:26:08 +00:00
committed by Tim Abbott
parent 940b7e38f8
commit 343741f621
4 changed files with 40 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/views/streams.py
View File

@@ -81,6 +81,7 @@ from zerver.lib.user_groups import (
GroupSettingChangeRequest,
access_user_group_for_setting,
get_group_setting_value_for_api,
get_role_based_system_groups_dict,
parse_group_setting_value,
validate_group_setting_value_change,
)
@@ -594,6 +595,9 @@ def add_subscriptions_backend(
setting_groups_dict = {}
group_settings_map = {}
request_settings_dict = locals()
# We don't want to calculate this value if no default values are
# needed.
system_groups_name_dict = None
for setting_name, permission_configuration in Stream.stream_permission_group_settings.items():
assert setting_name in request_settings_dict
if request_settings_dict[setting_name] is not None:
@@ -607,8 +611,10 @@ def add_subscriptions_backend(
)
setting_groups_dict[group_settings_map[setting_name].id] = setting_value
else:
if system_groups_name_dict is None:
system_groups_name_dict = get_role_based_system_groups_dict(realm)
group_settings_map[setting_name] = get_stream_permission_default_group(
setting_name, realm
setting_name, system_groups_name_dict
)
setting_groups_dict[group_settings_map[setting_name].id] = group_settings_map[
setting_name