paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 07:52:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

cache: Do not fail the request on cache-set failures.

Browse Source 
Failure to update the cache should log an exception but continue.
This commit is contained in:
Alex Vandiver
2025-03-05 16:36:45 +00:00
committed by Tim Abbott
parent c4701fa8d5
commit 34f0e3b621
2 changed files with 40 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
zerver/lib/cache.py
View File

@@ -12,6 +12,7 @@ from functools import _lru_cache_wrapper, lru_cache, wraps
from itertools import islice, product
from typing import TYPE_CHECKING, Any, Generic, TypeVar
from bmemcached.exceptions import MemcachedException
from django.conf import settings
from django.core.cache import caches
from django.core.cache.backends.base import BaseCache
@@ -226,7 +227,10 @@ def cache_set(
remote_cache_stats_start()
cache_backend = get_cache_backend(cache_name)
cache_backend.set(final_key, (val,), timeout=timeout)
try:
cache_backend.set(final_key, (val,), timeout=timeout)
except MemcachedException as e:
logger.exception(e)
remote_cache_stats_finish()
@@ -278,7 +282,10 @@ def cache_set_many(
new_items[new_key] = item
items = new_items
remote_cache_stats_start()
get_cache_backend(cache_name).set_many(items, timeout=timeout)
try:
get_cache_backend(cache_name).set_many(items, timeout=timeout)
except MemcachedException as e:
logger.exception(e)
remote_cache_stats_finish()