tests: Consistently use assert_length helper.

This helper does some nice things like printing out
the data structure incase of failure.
This commit is contained in:
Abhijeet Prasad Bodas
2021-05-17 09:11:32 +05:30
committed by Tim Abbott
parent 4d45b45640
commit 352634a851
57 changed files with 448 additions and 448 deletions

View File

@@ -85,7 +85,7 @@ class UserPresenceModelTests(ZulipTestCase):
user_profile = self.example_user("hamlet")
email = user_profile.email
presence_dct = get_status_dict_by_realm(user_profile.realm_id)
self.assertEqual(len(presence_dct), 0)
self.assert_length(presence_dct, 0)
self.login_user(user_profile)
result = self.client_post("/json/users/me/presence", {"status": "active"})
@@ -93,12 +93,12 @@ class UserPresenceModelTests(ZulipTestCase):
slim_presence = False
presence_dct = get_status_dict_by_realm(user_profile.realm_id, slim_presence)
self.assertEqual(len(presence_dct), 1)
self.assert_length(presence_dct, 1)
self.assertEqual(presence_dct[email]["website"]["status"], "active")
slim_presence = True
presence_dct = get_status_dict_by_realm(user_profile.realm_id, slim_presence)
self.assertEqual(len(presence_dct), 1)
self.assert_length(presence_dct, 1)
info = presence_dct[str(user_profile.id)]
self.assertEqual(set(info.keys()), {"active_timestamp"})
@@ -110,12 +110,12 @@ class UserPresenceModelTests(ZulipTestCase):
# Simulate the presence being a week old first. Nothing should change.
back_date(num_weeks=1)
presence_dct = get_status_dict_by_realm(user_profile.realm_id)
self.assertEqual(len(presence_dct), 1)
self.assert_length(presence_dct, 1)
# If the UserPresence row is three weeks old, we ignore it.
back_date(num_weeks=3)
presence_dct = get_status_dict_by_realm(user_profile.realm_id)
self.assertEqual(len(presence_dct), 0)
self.assert_length(presence_dct, 0)
def test_push_tokens(self) -> None:
UserPresence.objects.all().delete()
@@ -129,7 +129,7 @@ class UserPresenceModelTests(ZulipTestCase):
def pushable() -> bool:
presence_dct = get_status_dict_by_realm(user_profile.realm_id)
self.assertEqual(len(presence_dct), 1)
self.assert_length(presence_dct, 1)
return presence_dct[email]["website"]["pushable"]
self.assertFalse(pushable())