paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 07:52:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: Rename confusing hide-date CSS class.

Browse Source 
The previous hide-date CSS class had a semantic meaning of "this
recipient row has the same date as the previous one"; since we're now
having logic read that value, it's worth giving it a semantic name
that makes that code easier to understand.
This commit is contained in:
Tim Abbott
2023-03-21 12:20:33 -07:00
parent 404f6a404a
commit 35440672a7
3 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
web/src/message_list_view.js
View File

@@ -116,12 +116,12 @@ function update_group_date(group, message_container, prev) {
const today = new Date();
// Show the date in the recipient bar if the previous message was from a different day.
group.show_recipient_bar_date = !same_day(message_container, prev);
group.date_unchanged = same_day(message_container, prev);
group.group_date_html = timerender.render_date(time, today)[0].outerHTML;
}
function clear_group_date(group) {
group.show_recipient_bar_date = true;
group.date_unchanged = false;
group.group_date_html = undefined;
}
@@ -1542,12 +1542,9 @@ export class MessageListView {
// hiding the date display on the non-sticky previous
// recipient row.
$(".hide-date-separator-header").removeClass("hide-date-separator-header");
// The hide-date CSS class is set on recipient_row_date
// elements where the previous row had the same date; these
// will only display the date when sticky. Since this corner
// case only is relevant with an identical date, we start by
// checking whether the hide-date class is present.
if ($sticky_header.find(".recipient_row_date.hide-date").length) {
// This corner case only occurs when the date is unchanged
// from the previous recipient row.
if ($sticky_header.find(".recipient_row_date.recipient_row_date_unchanged").length) {
const $prev_recipient_row = $sticky_header
.closest(".recipient_row")
.prev(".recipient_row");
@@ -1556,7 +1553,7 @@ export class MessageListView {
}
const $prev_header_date_row = $prev_recipient_row.find(".recipient_row_date");
// Check if the recipient row before sticky header is a date separator.
if (!$prev_header_date_row.hasClass("hide-date")) {
if (!$prev_header_date_row.hasClass("recipient_row_date_unchanged")) {
$prev_header_date_row.addClass("hide-date-separator-header");
}
}