paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

groups: Remove id_field_name field from GroupPermissionSetting.

Browse Source 
id_field_name was being used only to set the initial dummy
values for realm settings. We can directly add "_id" to the
setting name instead of having an extra id_field_name field.
This commit is contained in:
Sahil Batra
2024-12-03 12:45:23 +05:30
committed by Tim Abbott
parent 121df45cc4
commit 367a0bdbff
12 changed files with 18 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/actions/create_realm.py
View File

@@ -245,8 +245,8 @@ def do_create_realm(
# For now a dummy value of -1 is given to groups fields which
# is changed later before the transaction is committed.
for permission_configuration in Realm.REALM_PERMISSION_GROUP_SETTINGS.values():
setattr(realm, permission_configuration.id_field_name, -1)
for setting_name in Realm.REALM_PERMISSION_GROUP_SETTINGS:
setattr(realm, setting_name + "_id", -1)
realm.save()