paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 00:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Fix bug in undo operation

Browse Source 
This fixes compose.test_video_link_compose_clicked to just
use a stub for compose_ui.insert_syntax_and_focus.

It also adds direct tests for compose_ui.insert_syntax_and_focus.

Fixes #6362
This commit is contained in:
Steve Howell
2017-12-08 07:17:20 -08:00
parent e5c05f128a
commit 36ade63d84
3 changed files with 41 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/compose_ui.js
View File

@@ -27,8 +27,15 @@ exports.smart_insert = function (textarea, syntax) {
}
}
textarea.caret(syntax);
textarea.focus();
// We prefer to use insertText, which supports things like undo better
// for rich-text editing features like inserting links. But we fall
// back to textarea.caret if the browser doesn't support insertText.
if (!document.execCommand("insertText", false, syntax)) {
textarea.caret(syntax);
}
// This should just call exports.autosize_textarea, but it's a bit
// annoying for the unit tests, so we don't do that.
textarea.trigger("autosize.resize");