home.py: move autoscroll_forever to register_ret.

Move the user_profile data section down into fetch_initial_state_data so
it entirely pulls from register_ret for #3853

zerver/lib/events.py

@@ -165,6 +165,7 @@ def fetch_initial_state_data(user_profile, event_types, queue_id,
         state['emojiset_choices'] = user_profile.emojiset_choices()
         state['timezone'] = user_profile.timezone
         state['default_language'] = user_profile.default_language
+        state['autoscroll_forever'] = user_profile.autoscroll_forever
 
     if want('update_global_notifications'):
         state['default_desktop_notifications'] = user_profile.default_desktop_notifications

zerver/views/home.py

@@ -212,7 +212,6 @@ def home_real(request):
         user_id               = user_profile.id,
         is_admin              = user_profile.is_realm_admin,
         can_create_streams    = user_profile.can_create_streams(),
-        autoscroll_forever = user_profile.autoscroll_forever,
 
         # Realm foreign key data from register_ret.
         # TODO: Rename these to match register_ret values.
@@ -240,6 +239,7 @@ def home_real(request):
     page_params_core_fields = [
         'alert_words',
         'attachments',
+        'autoscroll_forever',
         'avatar_source',
         'avatar_url',
         'avatar_url_medium',