paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

analytics: Remove COUNT_STATS['messages_sent:hour'].

Browse Source 
Having both messages_sent:hour and messages_sent:is_bot:day is confusing,
since a single messages_sent:is_bot:hour would have a superset of the
information and take less total space. This commit and its parent together
replace the two stats with a single messages_sent:is_bot:hour.
This commit is contained in:
Rishi Gupta
2017-01-16 13:42:09 -08:00
committed by Tim Abbott
parent b593ac9d7c
commit 37bdc7c010
3 changed files with 1 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
analytics/tests/test_counts.py
View File

@@ -246,32 +246,6 @@ class TestCountStats(AnalyticsTestCase):
self.assertTableState(UserCount, [], [])
self.assertTableState(StreamCount, [], [])
def test_messages_sent(self):
# type: () -> None
stat = COUNT_STATS['messages_sent:hour']
self.current_property = stat.property
# Nothing in this query should be bot-related
user1 = self.create_user(is_bot=True)
user2 = self.create_user()
recipient_user2 = Recipient.objects.create(type_id=user2.id, type=Recipient.PERSONAL)
recipient_stream = self.create_stream_with_recipient()[1]
recipient_huddle = self.create_huddle_with_recipient()[1]
self.create_message(user1, recipient_user2)
self.create_message(user2, recipient_user2)
self.create_message(user2, recipient_stream)
self.create_message(user2, recipient_huddle)
do_fill_count_stat_at_hour(stat, self.TIME_ZERO)
self.assertTableState(UserCount, ['value', 'user'],
[[1, user1], [3, user2], [1, self.hourly_user]])
self.assertTableState(RealmCount, ['value', 'realm'], [[4], [1, self.second_realm]])
self.assertTableState(InstallationCount, ['value'], [[5]])
self.assertTableState(StreamCount, [], [])
def test_messages_sent_by_is_bot(self):
# type: () -> None
stat = COUNT_STATS['messages_sent:is_bot:hour']