paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

frontend: Use topic on message.

Browse Source 
This seems like a small change (apart from all the
test changes), but it fundamentally changes how
the app finds "topic" on message objects.  Now
all code that used to set "subject" now sets "topic"
on message-like objects.  We convert incoming messages
to have topic, and we write to "topic" all the way up
to hitting the server (which now accepts "topic" on
incoming endpoints).

We fall back to subject as needed, but the code will
emit a warning that should be heeded--the "subject"
field is prone to becoming stale for things like
topic changes.
This commit is contained in:
Steve Howell
2018-12-23 15:49:14 +00:00
committed by Tim Abbott
parent 534bf8f806
commit 37c78abe14
23 changed files with 142 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
frontend_tests/node_tests/recent_senders.js
View File

@@ -18,13 +18,13 @@ run_test('process_message_for_senders', () => {
var message1 = {
stream_id: stream1,
id: _.uniqueId(),
subject: topic1,
topic: topic1,
sender_id: sender1,
};
var message2 = {
stream_id: stream2,
id: _.uniqueId(),
subject: topic1,
topic: topic1,
sender_id: sender2,
};
rs.process_message_for_senders(message1);
@@ -47,7 +47,7 @@ run_test('process_message_for_senders', () => {
var message3 = {
stream_id: stream1,
id: _.uniqueId(),
subject: topic2,
topic: topic2,
sender_id: sender3,
};
rs.process_message_for_senders(message3);
@@ -59,7 +59,7 @@ run_test('process_message_for_senders', () => {
var message4 = {
stream_id: stream1,
id: _.uniqueId(),
subject: topic1,
topic: topic1,
sender_id: sender2,
};
rs.process_message_for_senders(message4);
@@ -71,7 +71,7 @@ run_test('process_message_for_senders', () => {
var message5 = {
stream_id: stream1,
id: _.uniqueId(),
subject: topic1,
topic: topic1,
sender_id: sender1,
};
rs.process_message_for_senders(message5);
@@ -83,19 +83,19 @@ run_test('process_message_for_senders', () => {
var message6 = {
stream_id: stream3,
id: _.uniqueId(),
subject: topic1,
topic: topic1,
sender_id: sender1,
};
var message7 = {
stream_id: stream3,
id: _.uniqueId(),
subject: topic2,
topic: topic2,
sender_id: sender2,
};
var message8 = {
stream_id: stream3,
id: _.uniqueId(),
subject: topic3,
topic: topic3,
sender_id: sender3,
};