paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

webhook tests: Rename main helper to check_webhook.

Browse Source 
Almost all webhook tests use this helper, except a few
webhooks that write to private streams.

Being concise is important here, and the name
`self.send_and_test_stream_message` always confused
me, since it sounds you're sending a stream message,
and it leaves out the webhook piece.

We should consider renaming `send_and_test_private_message`
to something like `check_webhook_private`, but I couldn't
decide on a great name, and it's very rarely used.  So
for now I just made sure the docstrings of the two
sibling functions reference each other.
This commit is contained in:
Steve Howell
2020-08-23 13:49:24 +00:00
committed by Tim Abbott
parent 00001a396b
commit 388053db6b
71 changed files with 1726 additions and 1467 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/webhooks/appveyor/tests.py
View File

@@ -18,7 +18,7 @@ class AppveyorHookTests(WebhookTestCase):
* **Finished**: 9/9/2018 7:06 PM
""".strip()
self.send_and_test_stream_message('appveyor_build_success', expected_topic, expected_message)
self.check_webhook("appveyor_build_success", expected_topic, expected_message)
def test_appveyor_build_failure_message(self) -> None:
"""
@@ -32,7 +32,7 @@ class AppveyorHookTests(WebhookTestCase):
* **Finished**: 9/9/2018 7:06 PM
""".strip()
self.send_and_test_stream_message('appveyor_build_failure', expected_topic, expected_message)
self.check_webhook("appveyor_build_failure", expected_topic, expected_message)
def get_body(self, fixture_name: str) -> str:
return self.webhook_fixture_data("appveyor", fixture_name, file_type="json")