webhook tests: Rename main helper to check_webhook.

Almost all webhook tests use this helper, except a few
webhooks that write to private streams.

Being concise is important here, and the name
`self.send_and_test_stream_message` always confused
me, since it sounds you're sending a stream message,
and it leaves out the webhook piece.

We should consider renaming `send_and_test_private_message`
to something like `check_webhook_private`, but I couldn't
decide on a great name, and it's very rarely used.  So
for now I just made sure the docstrings of the two
sibling functions reference each other.
This commit is contained in:
Steve Howell
2020-08-23 13:49:24 +00:00
committed by Tim Abbott
parent 00001a396b
commit 388053db6b
71 changed files with 1726 additions and 1467 deletions

View File

@@ -14,8 +14,8 @@ class GocdHookTests(WebhookTestCase):
"/go/tab/pipeline/history/pipelineName)\n"
"Comment: my hola mundo changes")
self.send_and_test_stream_message(
'pipeline',
self.check_webhook(
"pipeline",
self.TOPIC,
expected_message,
content_type="application/x-www-form-urlencoded",
@@ -28,8 +28,8 @@ class GocdHookTests(WebhookTestCase):
"/go/tab/pipeline/history/pipelineName)\n"
"Comment: my hola mundo changes")
self.send_and_test_stream_message(
'pipeline_failed',
self.check_webhook(
"pipeline_failed",
self.TOPIC,
expected_message,
content_type="application/x-www-form-urlencoded",