paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Check for object equality instead of type equality.

Browse Source 
I don't see any strong reason to do only type equality
when we can do object equality here.
This commit is contained in:
Vishnu KS
2020-03-12 13:35:14 +05:30
committed by Tim Abbott
parent 1388a1d2b1
commit 388384e894
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
corporate/tests/test_stripe.py
View File

@@ -1139,16 +1139,16 @@ class BillingHelpersTest(ZulipTestCase):
mocked1.assert_called() mocked1.assert_called()
self.assertEqual(returned, 'returned') self.assertEqual(returned, 'returned')
# Customer exists, replace payment source # Customer exists, replace payment source
Customer.objects.create(realm=get_realm('zulip'), stripe_customer_id='cus_12345') customer = Customer.objects.create(realm=get_realm('zulip'), stripe_customer_id='cus_12345')
with patch('corporate.lib.stripe.do_replace_payment_source') as mocked2: with patch('corporate.lib.stripe.do_replace_payment_source') as mocked2:
customer = update_or_create_stripe_customer(self.example_user('hamlet'), 'token') returned_customer = update_or_create_stripe_customer(self.example_user('hamlet'), 'token')
mocked2.assert_called() mocked2.assert_called()
self.assertTrue(isinstance(customer, Customer)) self.assertEqual(returned_customer, customer)
# Customer exists, do nothing # Customer exists, do nothing
with patch('corporate.lib.stripe.do_replace_payment_source') as mocked3: with patch('corporate.lib.stripe.do_replace_payment_source') as mocked3:
customer = update_or_create_stripe_customer(self.example_user('hamlet'), None) returned_customer = update_or_create_stripe_customer(self.example_user('hamlet'), None)
mocked3.assert_not_called() mocked3.assert_not_called()
self.assertTrue(isinstance(customer, Customer)) self.assertEqual(returned_customer, customer)
def test_get_customer_by_realm(self) -> None: def test_get_customer_by_realm(self) -> None:
realm = get_realm('zulip') realm = get_realm('zulip')