paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 03:11:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

recent: Sort PM recipients by their last sent message id.

Browse Source 
Fixes #23563
This commit is contained in:
Aman Agrawal
2022-11-19 06:39:00 +00:00
committed by Tim Abbott
parent c0ad0b3b10
commit 38a4751b7b
5 changed files with 90 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
static/js/recent_topics_ui.js
View File

@@ -430,10 +430,6 @@ function format_conversation(conversation_data) {
context.pm_url = last_msg.pm_with_url;
context.is_group = last_msg.display_recipient.length > 2;
// Display in most recent sender first order
all_senders = last_msg.display_recipient;
senders = all_senders.slice(-MAX_AVATAR).map((sender) => sender.id);
if (!context.is_group) {
const user_id = Number.parseInt(last_msg.to_user_ids, 10);
const user = people.get_by_user_id(user_id);
@@ -446,6 +442,17 @@ function format_conversation(conversation_data) {
}
}
// Since the css for displaying senders in reverse order is much simpler,
// we provide our handlebars with senders in opposite order.
// Display in most recent sender first order.
// To match the behavior for streams, we display the set of users who've actually
// participated, with the most recent participants first. It could make sense to
// display the other recipients on the PM conversation with different styling,
// but it's important to not destroy the information of "who's actually talked".
all_senders = recent_senders
.get_pm_recent_senders(context.user_ids_string)
.participants.reverse();
senders = all_senders.slice(-MAX_AVATAR);
// Collect extra senders fullname for tooltip.
extra_sender_ids = all_senders.slice(0, -MAX_AVATAR);
displayed_other_senders = extra_sender_ids