paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 19:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

hotkey: Specify reactions toggle to message controls.

Browse Source 
Sometimes this selector was catching a second
`emoji-message-control-button-container` from an emoji reaction,
which was only caught once we started using `util.the`. This
change avoids catching that irrelevant element.
This commit is contained in:
Evy Kassirer
2025-10-09 21:02:30 -07:00
committed by Tim Abbott
parent 898b544ba4
commit 38e7f11259
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/hotkey.ts
View File

@@ -1378,7 +1378,9 @@ function process_hotkey(e: JQuery.KeyDownEvent, hotkey: Hotkey): boolean {
// ':': open reactions to message // ':': open reactions to message
case "toggle_reactions_popover": { case "toggle_reactions_popover": {
const $row = message_lists.current.selected_row(); const $row = message_lists.current.selected_row();
const $emoji_icon = $row.find(".emoji-message-control-button-container"); const $emoji_icon = $row.find(
".message_controls .emoji-message-control-button-container",
);
let emoji_picker_reference; let emoji_picker_reference;
if ( if (
$emoji_icon?.length !== 0 && $emoji_icon?.length !== 0 &&

2
web/tests/hotkey.test.cjs
View File

@@ -107,7 +107,7 @@ message_lists.current = {
selected_row() { selected_row() {
const $row = $.create("selected-row-stub"); const $row = $.create("selected-row-stub");
$row.set_find_results(".message-actions-menu-button", ["<menu-button-stub>"]); $row.set_find_results(".message-actions-menu-button", ["<menu-button-stub>"]);
$row.set_find_results(".emoji-message-control-button-container", { $row.set_find_results(".message_controls .emoji-message-control-button-container", {
closest: () => ({css: () => "none"}), closest: () => ({css: () => "none"}),
}); });
return $row; return $row;