paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 08:56:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

typing_status: Use TypeScript unions for 'Recipient' type.

Browse Source 
Typing 'Recipient' as union of 'stream' and 'direct' message type will help with upcoming type inference.
This commit is contained in:
Varun Singh
2024-01-24 00:16:07 +05:30
committed by Tim Abbott
parent b64a9d6ae0
commit 391e2a8e01
4 changed files with 61 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
web/shared/src/typing_status.js.flow
View File

@@ -4,16 +4,23 @@
"use strict";
type RecipientUserIds<UserId: number> = $ReadOnlyArray<UserId>;
type StreamTopicObject = {|stream_id: number, topic: string|};
type DirectMessageObject<UserId: number> = {|
message_type: string,
ids: $ReadOnlyArray<UserId>,
|};
type StreamObject = {|
message_type: string,
stream_id: number,
topic: string,
|};
type Worker<UserId> = {|
get_current_time: () => number, // as ms since epoch
notify_server_start: (RecipientUserIds<UserId> | StreamTopicObject) => void,
notify_server_stop: (RecipientUserIds<UserId> | StreamTopicObject) => void,
notify_server_start: (DirectMessageObject<UserId> | StreamObject) => void,
notify_server_stop: (DirectMessageObject<UserId> | StreamObject) => void,
|};
declare export function update<UserId>(
worker: Worker<UserId>,
new_recipient: RecipientUserIds<UserId> | StreamTopicObject | null,
new_recipient: DirectMessageObject<UserId> | StreamObject | null,
): void;