paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer: Replace hidden: false with visible: true.

Browse Source 
I had a misconception with hidden and visible options
and thought `hidden: false` was same as `visible: true`
and other way too.

But `hidden: false` or `visible: false` does nothing
more than checking if the selector exists.

Also, to mention, `visible: false`'s were fixed in
33e19fa7d1
This commit is contained in:
Dinesh
2020-08-11 16:08:47 +00:00
committed by Tim Abbott
parent 28c627452f
commit 3b3ed0c2d5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/puppeteer_tests/03-compose.js
View File

@@ -98,12 +98,12 @@ async function test_reply_with_r_shortcut(page) {
}
async function test_open_close_compose_box(page) {
await page.waitForSelector("#stream-message", {hidden: false});
await page.waitForSelector("#stream-message", {visible: true});
await close_compose_box(page);
await page.waitForSelector("#stream-message", {hidden: true});
await page.keyboard.press("KeyX");
await page.waitForSelector("#private-message", {hidden: false});
await page.waitForSelector("#private-message", {visible: true});
await close_compose_box(page);
await page.waitForSelector("#private-message", {hidden: true});
}