diff --git a/templates/zerver/development/dev_tools.html b/templates/zerver/development/dev_tools.html index 3787e5f43a..4d6dd01d8b 100644 --- a/templates/zerver/development/dev_tools.html +++ b/templates/zerver/development/dev_tools.html @@ -166,7 +166,7 @@

Serve static build (supports search but not hot reload)

Please run ./tools/build-help-center to generate a static build of the help center. - ./tools/run-dev --help-center will host the generated build on + ./tools/run-dev --help-center-static-build will host the generated build on /help. Note that you need to generate a build and pass the flag mentioned for the search to work.

diff --git a/tools/lib/test_server.py b/tools/lib/test_server.py index 13f73ef7da..7faf294b82 100644 --- a/tools/lib/test_server.py +++ b/tools/lib/test_server.py @@ -77,7 +77,7 @@ def test_server_running( if skip_provision_check: run_dev_server_command.append("--skip-provision-check") if enable_help_center: - run_dev_server_command.append("--help-center") + run_dev_server_command.append("--help-center-static-build") server = subprocess.Popen(run_dev_server_command, stdout=log, stderr=log) try: diff --git a/tools/run-dev b/tools/run-dev index e7a9976926..e2fe7b7bf0 100755 --- a/tools/run-dev +++ b/tools/run-dev @@ -66,7 +66,9 @@ parser.add_argument( help="Start app server in HTTPS mode, using reverse proxy", ) parser.add_argument( - "--help-center", action="store_true", help="Build and host help center with search" + "--help-center-static-build", + action="store_true", + help="Host existing static build of help center with search", ) parser.add_argument( "--help-center-dev-server", @@ -80,7 +82,9 @@ parser.add_argument( ) add_provision_check_override_param(parser) options = parser.parse_args() -help_center_dev_server_enabled = options.help_center_dev_server and not options.help_center +help_center_dev_server_enabled = ( + options.help_center_dev_server and not options.help_center_static_build +) assert_provisioning_status_ok(options.skip_provision_check) @@ -333,7 +337,7 @@ async def help_center_middleware( middlewares = [] -if options.help_center: +if options.help_center_static_build: middlewares.append(help_center_middleware) app = web.Application(middlewares=middlewares) @@ -458,7 +462,7 @@ async def serve() -> None: if help_center_dev_server_enabled: children.append(run_help_center_dev_server(external_host_url)) - setup_routes(options.help_center, options.help_center_dev_server) + setup_routes(options.help_center_static_build, options.help_center_dev_server) children.extend(subprocess.Popen(cmd) for cmd in server_processes())