paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

outgoing_webhook: Avoid logging a bytes string.

Browse Source 
This fixes the new assertLogs() tests failing in CI; we fixed the
weird use of bytes in the test, but not in the runtime code.
This commit is contained in:
Tim Abbott
2020-10-29 15:55:09 -07:00
parent 7106069d4d
commit 3b9c726fc6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/outgoing_webhook.py
View File

@@ -310,7 +310,7 @@ def do_rest_call(base_url: str,
"%(response)s\"", "%(response)s\"",
{'message_url': get_message_url(event), {'message_url': get_message_url(event),
'status_code': response.status_code, 'status_code': response.status_code,
'response': response.content}) 'response': response.content.decode()})
failure_message = f"Third party responded with {response.status_code}" failure_message = f"Third party responded with {response.status_code}"
fail_with_message(event, failure_message) fail_with_message(event, failure_message)
notify_bot_owner(event, response.status_code, response.content) notify_bot_owner(event, response.status_code, response.content)