paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

zilencer: Improve json error when plan doesn't allow push notifs.

Browse Source 
This allows the self-hosted server to explicitly test for that exception
and catch and log it nicely.
This commit is contained in:
Mateusz Mandera
2024-02-06 23:02:01 +01:00
committed by Tim Abbott
parent d29cd04387
commit 3bda31c48c
3 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
zilencer/views.py
View File

@@ -472,6 +472,16 @@ class OldZulipServerError(JsonableError):
self._msg: str = msg
class PushNotificationsDisallowedError(JsonableError):
code = ErrorCode.PUSH_NOTIFICATIONS_DISALLOWED
def __init__(self, reason: str) -> None:
msg = _(
"Your plan doesn't allow sending push notifications. Reason provided by the server: {reason}"
).format(reason=reason)
super().__init__(msg)
@has_request_variables
def remote_server_notify_push(
request: HttpRequest,
@@ -502,7 +512,8 @@ def remote_server_notify_push(
if server.last_api_feature_level is None:
raise OldZulipServerError(_("Your plan doesn't allow sending push notifications."))
else:
raise JsonableError(_("Your plan doesn't allow sending push notifications."))
reason = push_status.message
raise PushNotificationsDisallowedError(reason=reason)
android_devices = list(
RemotePushDeviceToken.objects.filter(