paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

backend: Add request as parameter to json_success.

Browse Source 
Adds request as a parameter to json_success as a refactor towards
making `ignored_parameters_unsupported` functionality available
for all API endpoints.

Also, removes any data parameters that are an empty dict or
a dict with the generic success response values.
This commit is contained in:
Lauryn Menard
2022-01-31 13:44:02 +01:00
committed by Tim Abbott
parent 6f7e53c517
commit 3be622ffa7
139 changed files with 304 additions and 294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/views/user_settings.py
View File

@@ -315,7 +315,7 @@ def json_change_settings(
if len(request_notes.ignored_parameters) > 0:
result["ignored_parameters_unsupported"] = list(request_notes.ignored_parameters)
return json_success(result)
return json_success(request, data=result)
def set_avatar_backend(request: HttpRequest, user_profile: UserProfile) -> HttpResponse:
@@ -339,7 +339,7 @@ def set_avatar_backend(request: HttpRequest, user_profile: UserProfile) -> HttpR
json_result = dict(
avatar_url=user_avatar_url,
)
return json_success(json_result)
return json_success(request, data=json_result)
def delete_avatar_backend(request: HttpRequest, user_profile: UserProfile) -> HttpResponse:
@@ -354,7 +354,7 @@ def delete_avatar_backend(request: HttpRequest, user_profile: UserProfile) -> Ht
json_result = dict(
avatar_url=gravatar_url,
)
return json_success(json_result)
return json_success(request, data=json_result)
# We don't use @human_users_only here, because there are use cases for
@@ -365,4 +365,4 @@ def regenerate_api_key(request: HttpRequest, user_profile: UserProfile) -> HttpR
json_result = dict(
api_key=new_api_key,
)
return json_success(json_result)
return json_success(request, data=json_result)