paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

people: Downgrade late added user errors for spectators.

Browse Source 
As noted in the comment, this condition is expected to happen for
spectator users.
This commit is contained in:
Tim Abbott
2023-05-30 16:50:47 -07:00
committed by Alex Vandiver
parent 1c84f02f57
commit 3c60e538f9
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/people.js
View File

@@ -1269,7 +1269,13 @@ export function deactivate(person) {
} }
export function report_late_add(user_id, email) { export function report_late_add(user_id, email) {
if (reload_state.is_in_progress()) { // If the events system is not running, then it is expected that
// we will fetch messages from the server that were sent by users
// who don't exist in our users data set. This can happen because
// we're in the middle of a reload (and thus stopped our event
// queue polling) or because we are a spectator and never had an
// event queue in the first place.
if (reload_state.is_in_progress() || page_params.is_spectator) {
blueslip.log("Added user late", {user_id, email}); blueslip.log("Added user late", {user_id, email});
} else { } else {
blueslip.error("Added user late", {user_id, email}); blueslip.error("Added user late", {user_id, email});

4
web/src/server_events.js
View File

@@ -154,8 +154,8 @@ function get_events({dont_block = false} = {}) {
} }
// TODO: In the future, we may implement Tornado support for live // TODO: In the future, we may implement Tornado support for live
// update for spectator, but until then, there's nothing // update for spectators (#20315), but until then, there's nothing
// to do here. // to do here. Update report_late_add if this changes.
if (page_params.is_spectator) { if (page_params.is_spectator) {
return; return;
} }