paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 16:14:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

draft_overlay: Clarify the editing UI for drafts.

Browse Source 
Co-authored-by: Sayam Samal <sayam@zulip.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
This commit is contained in:
apoorvapendse
2025-04-12 11:12:27 +05:30
committed by Tim Abbott
parent 3dc54a10d7
commit 3cd0f87d47
6 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
web/src/drafts_overlay_ui.ts
View File

@@ -387,7 +387,6 @@ export function launch(): void {
messages_overlay_ui.set_initial_element(first_element_id, keyboard_handling_context); messages_overlay_ui.set_initial_element(first_element_id, keyboard_handling_context);
setup_event_handlers(); setup_event_handlers();
setup_bulk_actions_handlers(); setup_bulk_actions_handlers();
messages_overlay_ui.initialize_restore_overlay_message_tooltip();
} }
export function update_bulk_delete_ui(): void { export function update_bulk_delete_ui(): void {

5
web/styles/settings.css
View File

@@ -582,6 +582,11 @@ input[type="checkbox"] {
margin: 0 2px; margin: 0 2px;
} }
.overlay-keyboard-shortcuts .popover-menu-hotkey-hints {
display: inline-flex;
padding-left: 0;
}
.edit-attachment-buttons { .edit-attachment-buttons {
display: inline-block; display: inline-block;
vertical-align: middle; vertical-align: middle;

3
web/templates/draft.hbs
View File

@@ -50,14 +50,13 @@
<span class="copy-button copy-overlay-message tippy-zulip-delayed-tooltip" data-draft-id="{{draft_id}}" data-tippy-content="{{t 'Copy draft' }}" aria-label="{{t 'Copy draft' }}" role="button"> <span class="copy-button copy-overlay-message tippy-zulip-delayed-tooltip" data-draft-id="{{draft_id}}" data-tippy-content="{{t 'Copy draft' }}" aria-label="{{t 'Copy draft' }}" role="button">
<i class="zulip-icon zulip-icon-copy" aria-hidden="true"></i> <i class="zulip-icon zulip-icon-copy" aria-hidden="true"></i>
</span> </span>
<i class="fa fa-pencil fa-lg restore-overlay-message tippy-zulip-delayed-tooltip" aria-hidden="true" data-tooltip-template-id="restore-draft-tooltip-template"></i>
{{> ./components/icon_button intent="danger" custom_classes="delete-overlay-message tippy-zulip-delayed-tooltip" icon="trash" data-tooltip-template-id="delete-draft-tooltip-template" aria-label=(t "Delete") }} {{> ./components/icon_button intent="danger" custom_classes="delete-overlay-message tippy-zulip-delayed-tooltip" icon="trash" data-tooltip-template-id="delete-draft-tooltip-template" aria-label=(t "Delete") }}
<div class="draft-selection-tooltip"> <div class="draft-selection-tooltip">
<i class="fa fa-square-o fa-lg draft-selection-checkbox" aria-hidden="true"></i> <i class="fa fa-square-o fa-lg draft-selection-checkbox" aria-hidden="true"></i>
</div> </div>
</div> </div>
</div> </div>
<div class="message_content rendered_markdown restore-overlay-message" data-tooltip-template-id="restore-draft-tooltip-template">{{rendered_markdown content}}</div> <div class="message_content rendered_markdown restore-overlay-message">{{rendered_markdown content}}</div>
</div> </div>
</div> </div>
</div> </div>

8
web/templates/draft_table_body.hbs
View File

@@ -9,7 +9,13 @@
<div id="draft_overlay_banner_container" class="banner-container"></div> <div id="draft_overlay_banner_container" class="banner-container"></div>
<div class="header-body"> <div class="header-body">
<div class="drafts-header-note"> <div class="drafts-header-note">
{{t "Drafts are not synced to other devices and browsers." }} <div class="overlay-keyboard-shortcuts">
{{#tr}}
To restore a draft, click on it or press <z-shortcut></z-shortcut>.
{{#*inline "z-shortcut"}}{{popover_hotkey_hints "Enter"}}{{/inline}}
{{/tr}}
</div>
<div>{{t "Drafts are not synced to other devices and browsers." }}</div>
</div> </div>
<div class="delete-drafts-group"> <div class="delete-drafts-group">
<div class="delete-selected-drafts-button-container"> <div class="delete-selected-drafts-button-container">

4
web/templates/tooltip_templates.hbs
View File

@@ -94,10 +94,6 @@
{{t 'Delete draft' }} {{t 'Delete draft' }}
{{tooltip_hotkey_hints "Backspace"}} {{tooltip_hotkey_hints "Backspace"}}
</template> </template>
<template id="restore-draft-tooltip-template">
{{t 'Restore draft' }}
{{tooltip_hotkey_hints "Enter"}}
</template>
<template id="gear-menu-tooltip-template"> <template id="gear-menu-tooltip-template">
{{t 'Main menu' }} {{t 'Main menu' }}
{{tooltip_hotkey_hints "G"}} {{tooltip_hotkey_hints "G"}}

1
web/tests/drafts.test.cjs
View File

@@ -10,7 +10,6 @@ const $ = require("./lib/zjquery.cjs");
const user_pill = mock_esm("../src/user_pill"); const user_pill = mock_esm("../src/user_pill");
const settings_data = mock_esm("../src/settings_data"); const settings_data = mock_esm("../src/settings_data");
const messages_overlay_ui = mock_esm("../src/messages_overlay_ui"); const messages_overlay_ui = mock_esm("../src/messages_overlay_ui");
messages_overlay_ui.initialize_restore_overlay_message_tooltip = noop;
const people = zrequire("people"); const people = zrequire("people");
const compose_state = zrequire("compose_state"); const compose_state = zrequire("compose_state");