paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

provision: Avoid spending ~1.5s on compilemessages in no-op case.

Browse Source 
This brings the total no-op provision time down to around 7.3s!

Tweaked by tabbott to clean up the code, close file descriptions, and
avoid issues with a somehow corrupted file.

Fixes #5185.
This commit is contained in:
sinwar
2017-06-14 15:02:34 +05:30
committed by Tim Abbott
parent 7387e6fe4b
commit 3d0b5b14be
1 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tools/lib/provision.py
View File

@@ -6,6 +6,7 @@ import logging
import argparse import argparse
import platform import platform
import subprocess import subprocess
import glob
import hashlib import hashlib
os.environ["PYTHONUNBUFFERED"] = "y" os.environ["PYTHONUNBUFFERED"] = "y"
@@ -277,6 +278,7 @@ def main(options):
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "zproject.settings") os.environ.setdefault("DJANGO_SETTINGS_MODULE", "zproject.settings")
import django import django
django.setup() django.setup()
from zerver.lib.str_utils import force_bytes
from zerver.lib.test_fixtures import is_template_database_current from zerver.lib.test_fixtures import is_template_database_current
if options.is_force or not is_template_database_current( if options.is_force or not is_template_database_current(
@@ -295,7 +297,28 @@ def main(options):
else: else:
print("No need to regenerate the test DB.") print("No need to regenerate the test DB.")
# Consider updating generated translations data: both `.mo`
# files and `language-options.json`.
sha1sum = hashlib.sha1()
paths = ['zerver/management/commands/compilemessages.py']
paths += glob.glob('static/locale/*/LC_MESSAGES/*.po')
paths += glob.glob('static/locale/*/translations.json')
for path in paths:
with open(path, 'r') as file_to_hash:
sha1sum.update(force_bytes(file_to_hash.read()))
new_compilemessages_hash = sha1sum.hexdigest()
run(['touch', 'var/last_compilemessages_hash'])
with open('var/last_compilemessages_hash', 'r') as hash_file:
last_compilemessages_hash = hash_file.read()
if options.is_force or (new_compilemessages_hash != last_compilemessages_hash):
with open('var/last_compilemessages_hash', 'w') as hash_file:
hash_file.write(new_compilemessages_hash)
run(["./manage.py", "compilemessages"]) run(["./manage.py", "compilemessages"])
else:
print("No need to run `manage.py compilemessages`.")
# Here we install nvm, node, and npm. # Here we install nvm, node, and npm.
run(["sudo", "scripts/lib/install-node"]) run(["sudo", "scripts/lib/install-node"])