paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

recent_topics: Don't show topics from unsubscribed streams.

Browse Source
This commit is contained in:
Aman Agrawal
2021-01-06 14:23:07 +00:00
committed by Tim Abbott
parent 017fbe3fe4
commit 3e36fe6a1e
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
frontend_tests/node_tests/recent_topics.js
View File

@@ -168,6 +168,7 @@ set_global("stream_data", {
// We only test via muted topics for now. // We only test via muted topics for now.
// TODO: Make muted streams and test them. // TODO: Make muted streams and test them.
false, false,
id_is_subscribed: () => true,
}); });
let id = 0; let id = 0;

5
static/js/recent_topics.js
View File

@@ -264,9 +264,10 @@ exports.update_topics_of_deleted_message_ids = function (message_ids) {
exports.filters_should_hide_topic = function (topic_data) { exports.filters_should_hide_topic = function (topic_data) {
const msg = message_store.get(topic_data.last_msg_id); const msg = message_store.get(topic_data.last_msg_id);
const sub = stream_data.get_sub_by_id(msg.stream_id);
if (stream_data.get_sub_by_id(msg.stream_id) === undefined) { if (sub === undefined || !sub.subscribed) {
// Never try to process deactivated streams. // Never try to process deactivated & unsubscribed stream msgs.
return true; return true;
} }