paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

playground_links_popover: Convert module to TypeScript.

Browse Source
This commit is contained in:
Varun Singh
2024-02-13 19:25:52 +05:30
committed by Tim Abbott
parent 44e4a90ab8
commit 3fa308369d
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/test-js-with-node
View File

@@ -161,7 +161,7 @@ EXEMPT_FILES = make_set(
"web/src/padded_widget.ts", "web/src/padded_widget.ts",
"web/src/page_params.ts", "web/src/page_params.ts",
"web/src/personal_menu_popover.js", "web/src/personal_menu_popover.js",
"web/src/playground_links_popover.js", "web/src/playground_links_popover.ts",
"web/src/plotly.js.d.ts", "web/src/plotly.js.d.ts",
"web/src/pm_list.js", "web/src/pm_list.js",
"web/src/pm_list_dom.ts", "web/src/pm_list_dom.ts",

26
web/src/playground_links_popover.js → web/src/playground_links_popover.ts
View File

@@ -1,4 +1,5 @@
import $ from "jquery"; import $ from "jquery";
import type {Instance as PopoverInstance, ReferenceElement} from "tippy.js";
import url_template_lib from "url-template"; import url_template_lib from "url-template";
import render_playground_links_popover from "../templates/popovers/playground_links_popover.hbs"; import render_playground_links_popover from "../templates/popovers/playground_links_popover.hbs";
@@ -6,14 +7,20 @@ import render_playground_links_popover from "../templates/popovers/playground_li
import * as blueslip from "./blueslip"; import * as blueslip from "./blueslip";
import * as popover_menus from "./popover_menus"; import * as popover_menus from "./popover_menus";
import * as realm_playground from "./realm_playground"; import * as realm_playground from "./realm_playground";
import type {RealmPlayground} from "./realm_playground";
import * as ui_util from "./ui_util"; import * as ui_util from "./ui_util";
let playground_links_popover_instance; type RealmPlaygroundWithURL = RealmPlayground & {playground_url: string};
let playground_links_popover_instance: PopoverInstance;
// Playground_store contains all the data we need to generate a popover of // Playground_store contains all the data we need to generate a popover of
// playground links for each code block. The element is the target element // playground links for each code block. The element is the target element
// to pop off of. // to pop off of.
function toggle_playground_links_popover(element, playground_store) { function toggle_playground_links_popover(
element: ReferenceElement,
playground_store: Map<number, RealmPlaygroundWithURL>,
): void {
if (is_open()) { if (is_open()) {
return; return;
} }
@@ -50,21 +57,20 @@ function toggle_playground_links_popover(element, playground_store) {
}); });
} }
export function is_open() { export function is_open(): boolean {
return Boolean(playground_links_popover_instance); return Boolean(playground_links_popover_instance);
} }
export function hide() { export function hide(): void {
if (is_open()) { if (is_open()) {
$(playground_links_popover_instance.reference) $(playground_links_popover_instance.reference)
.parent() .parent()
.removeClass("active-playground-links-reference"); .removeClass("active-playground-links-reference");
playground_links_popover_instance.destroy(); playground_links_popover_instance.destroy();
playground_links_popover_instance = undefined;
} }
} }
function get_playground_links_popover_items() { function get_playground_links_popover_items(): JQuery | undefined {
if (!is_open()) { if (!is_open()) {
blueslip.error("Trying to get menu items when playground links popover is closed."); blueslip.error("Trying to get menu items when playground links popover is closed.");
return undefined; return undefined;
@@ -79,12 +85,12 @@ function get_playground_links_popover_items() {
return $("li:not(.divider):visible a", $popover); return $("li:not(.divider):visible a", $popover);
} }
export function handle_keyboard(key) { export function handle_keyboard(key: string): void {
const $items = get_playground_links_popover_items(); const $items = get_playground_links_popover_items();
popover_menus.popover_items_handle_keyboard(key, $items); popover_menus.popover_items_handle_keyboard(key, $items);
} }
function register_click_handlers() { function register_click_handlers(): void {
$("#main_div, #preview_content, #message-history").on( $("#main_div, #preview_content, #message-history").on(
"click", "click",
".code_external_link", ".code_external_link",
@@ -107,7 +113,7 @@ function register_click_handlers() {
url_template.expand({code: extracted_code}), url_template.expand({code: extracted_code}),
); );
} else { } else {
const playground_store = new Map(); const playground_store = new Map<number, RealmPlaygroundWithURL>();
for (const playground of playground_info) { for (const playground of playground_info) {
const url_template = url_template_lib.parse(playground.url_template); const url_template = url_template_lib.parse(playground.url_template);
const playground_url = url_template.expand({code: extracted_code}); const playground_url = url_template.expand({code: extracted_code});
@@ -127,6 +133,6 @@ function register_click_handlers() {
}); });
} }
export function initialize() { export function initialize(): void {
register_click_handlers(); register_click_handlers();
} }

2
web/src/realm_playground.ts
View File

@@ -5,7 +5,7 @@ import * as typeahead from "../shared/src/typeahead";
import {$t} from "./i18n"; import {$t} from "./i18n";
import * as pygments_data from "./pygments_data"; import * as pygments_data from "./pygments_data";
type RealmPlayground = { export type RealmPlayground = {
id: number; id: number;
name: string; name: string;
pygments_language: string; pygments_language: string;