paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji: Switch to 64px 256 color indexed sprite sheets.

Browse Source 
This commit switches our emoji infrastructure to use 256 color indexed
64px spritesheets. Earlier we were using non-indexed 32px spritesheets
which were blurry on high dpi displays. These indexed spritesheets not
only provide a crispier display but are also smaller in size.

This commit also removes the `emoji-datasource` package as a dependency
as all the data is now sourced from individual datasource packages.

Fixes: #7862.
This commit is contained in:
Harshit Bansal
2018-03-13 19:34:31 +00:00
committed by Tim Abbott
parent 81a1612cbd
commit 40958e0824
8 changed files with 119 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/lib/zulip_tools.py
View File

@@ -272,14 +272,15 @@ def generate_sha1sum_emoji(zulip_path):
with open(file_path, 'rb') as reader:
sha.update(reader.read())
# Take into account the version of `emoji-datasource` package while generating success stamp.
# Take into account the version of `emoji-datasource-google` package
# while generating success stamp.
PACKAGE_FILE_PATH = os.path.join(zulip_path, 'package.json')
with open(PACKAGE_FILE_PATH, 'r') as fp:
parsed_package_file = json.load(fp)
dependency_data = parsed_package_file['dependencies']
if 'emoji-datasource' in dependency_data:
emoji_datasource_version = dependency_data['emoji-datasource'].encode('utf-8')
if 'emoji-datasource-google' in dependency_data:
emoji_datasource_version = dependency_data['emoji-datasource-google'].encode('utf-8')
else:
emoji_datasource_version = b"0"
sha.update(emoji_datasource_version)