paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 10:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

typeahead: Refactor switch statements to avoid fallthrough.

Browse Source
This commit is contained in:
evykassirer
2024-03-01 14:33:11 -08:00
committed by Tim Abbott
parent ff1f62bc56
commit 40b4db3323
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
web/third/bootstrap-typeahead/typeahead.js
View File

@@ -460,6 +460,9 @@ import {get_string_diff} from "../../src/util";
if (!this.options.tabIsEnter) { if (!this.options.tabIsEnter) {
return; return;
} }
e.preventDefault();
break;
case 13: // enter case 13: // enter
case 27: // escape case 27: // escape
e.preventDefault(); e.preventDefault();
@@ -521,6 +524,12 @@ import {get_string_diff} from "../../src/util";
if (!this.options.tabIsEnter) { if (!this.options.tabIsEnter) {
return; return;
} }
if (!this.shown) {
return;
}
this.select(e);
break;
case 13: // enter case 13: // enter
if (!this.shown) { if (!this.shown) {
return; return;
@@ -538,14 +547,15 @@ import {get_string_diff} from "../../src/util";
} }
break; break;
default:
// to stop typeahead from showing up momentarily // to stop typeahead from showing up momentarily
// when shift + tabbing to the topic field // when shift (keycode 16) + tabbing to the topic field
case 16: // shift if (
if (e.currentTarget.id === "stream_message_recipient_topic") { pseudo_keycode === 16 &&
e.currentTarget.id === "stream_message_recipient_topic"
) {
return; return;
} }
default:
var hideOnEmpty = false; var hideOnEmpty = false;
// backspace // backspace
if ( if (