paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

saved_snippets: Fix dropdown state sync across browser tabs.

Browse Source 
Currently, when the saved snippets are added or removed the changes
are not properly shown across different browser tabs if the dropdown is
open. This commit fixes this.
This commit is contained in:
Vector73
2025-02-14 04:22:44 +00:00
committed by Tim Abbott
parent 18a1a1e8e3
commit 41430661ee
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/dropdown_widget.ts
View File

@@ -51,7 +51,7 @@ export type DropdownWidgetOptions = {
// It is important to not pass `$("body")` here for widgets that would be `setup()`
// multiple times, so that we don't have duplicate event handlers.
$events_container: JQuery;
on_show_callback?: (instance: tippy.Instance) => void;
on_show_callback?: (instance: tippy.Instance, widget: DropdownWidget) => void;
on_mount_callback?: (instance: tippy.Instance) => void;
on_hidden_callback?: (instance: tippy.Instance) => void;
on_exit_with_escape_callback?: () => void;
@@ -88,7 +88,7 @@ export class DropdownWidget {
is_sticky_bottom_option_clicked: boolean,
) => void;
focus_target_on_hidden: boolean;
on_show_callback: (instance: tippy.Instance) => void;
on_show_callback: (instance: tippy.Instance, widget: DropdownWidget) => void;
on_mount_callback: (instance: tippy.Instance) => void;
on_hidden_callback: (instance: tippy.Instance) => void;
on_exit_with_escape_callback: () => void;
@@ -473,7 +473,7 @@ export class DropdownWidget {
}
}, 0);
this.on_show_callback(instance);
this.on_show_callback(instance, this);
this.adjust_dropdown_position_post_list_render(instance);
},
onMount: (instance: tippy.Instance) => {